Ive justed swaped over a ej25converion from a T3 bus to my dual cab T3. I am having a few issues. Usually the fual pump kicks in when the red are on and then seems to stop pumping after a second or two. but now mine just keeps pumping while the engine is off and just the reds are on. There is a black wire coming out of the relay that ive hooked up to earth but not sure if that is right. you can see it in the photo. Any ideas....

Usually the ECU activates the relay by earthing it. The relay you are holding in the photo is the main power relay, the fuel pump relay is the other one.

For the fuel pump relay
Red is power in for the pump, hot at all times
Yellow is power to coil, hot in run or start
Black/Red is power to the pump
Violet is earth from ecu to activate the relay( light green/black on earlier libertys)

Of course color are dependent on donor model.